Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subquery test code #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add subquery test code #82

wants to merge 4 commits into from

Conversation

bourbonkk
Copy link
Contributor

@bourbonkk bourbonkk commented Feb 17, 2023 •
edited
Loading

Hi, I wrote a test code for subquery. #15 #78

@jbguerraz @saketbairoliya2 @vigith

There were two code modifications.

  1. Query struct : "-,omitempty" -> "query,omitempty"
type Query struct {
	Base
	Query builder.Query `json:"query,omitempty"`
}

This is necessary to make a subquery.

  1. Lower struct : "locale,omitempty" -> "locale"
type Lower struct {
	Base
	Locale string `json:"locale"`
}
"extractionFn": {
"locale": "",
"type": "lower"
},

To express this example code,

This was referenced Feb 23, 2023
Open
Open
@jbguerraz
Copy link
Contributor

Hello @bourbonkk
Thank you!
I'm just back from vacation, I'll check it out ASAP (probably next week)

jbguerraz
jbguerraz requested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jbguerraz jbguerraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly there :) but we still have an issue with loading query (with subquery) from json

builder/extractionfn/lower.go Outdated Show resolved Hide resolved
builder/datasource/query.go Show resolved Hide resolved
@saketbairoliya2
Copy link
Contributor

@bourbonkk @jbguerraz - Any updates on this PR?

@bourbonkk
Copy link
Contributor Author

@saketbairoliya2 No, it doesn't.

@saketbairoliya2
Copy link
Contributor

@bourbonkk - So are we planning to merge this one or what's the further plan?

@bourbonkk
Copy link
Contributor Author

This PR has only reviews left.
@saketbairoliya2 @jbguerraz

@saketbairoliya2
Copy link
Contributor

Okay - May be @jbguerraz would be a better person to approve this PR. Waiting for him to get back. Thanks @bourbonkk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbguerraz jbguerraz Awaiting requested review from jbguerraz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bourbonkk @jbguerraz @saketbairoliya2